Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: use high priority for the hot region related operators #1492

Merged
merged 3 commits into from
Apr 8, 2019
Merged

scheduler: use high priority for the hot region related operators #1492

merged 3 commits into from
Apr 8, 2019

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Apr 3, 2019

What problem does this PR solve?

Hot region related operators should be the high priority.

What is changed and how it works?

This PR does the thing mentioned above.

Check List

Tests

  • Unit test

@rleungx
use high priority for the hot region related operators
4d1b357 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added the component/schedule Scheduling logic. label Apr 3, 2019
@rleungx rleungx requested review from nolouch and disksing April 3, 2019 07:41
@codecov-io
Copy link

codecov-io commented Apr 3, 2019 •
edited
Loading

Codecov Report

Merging #1492 into master will decrease coverage by 0.17%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1492      +/-   ##
==========================================
- Coverage   67.44%   67.27%   -0.18%     
==========================================
  Files         158      158              
  Lines       15459    15465       +6     
==========================================
- Hits        10427    10404      -23     
- Misses       4088     4110      +22     
- Partials      944      951       +7
Impacted Files Coverage Δ
server/config.go 82.35% <100%> (ø) ⬆️
server/schedulers/hot_region.go 76.83% <50%> (-0.61%) ⬇️
pkg/etcdutil/etcdutil.go 84.84% <0%> (-9.1%) ⬇️
server/etcd_kv.go 63.63% <0%> (-7.28%) ⬇️
server/schedulers/shuffle_hot_region.go 64.1% <0%> (-6.42%) ⬇️
server/api/redirector.go 78.94% <0%> (-5.27%) ⬇️
server/leader.go 78.57% <0%> (-4.21%) ⬇️
server/schedule/basic_cluster.go 88.67% <0%> (-3.78%) ⬇️
server/region_syncer/server.go 78.44% <0%> (-3.45%) ⬇️
server/util.go 70.27% <0%> (-2.71%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d3d7fb...0911778. Read the comment docs.

@rleungx rleungx merged commit cffb759 into tikv:master Apr 8, 2019
nolouch pushed a commit to nolouch/pd that referenced this pull request May 29, 2019
@rleungx @nolouch
use high priority for the hot region related operators (tikv#1492)
f0679a7 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx pushed a commit that referenced this pull request May 29, 2019
@nolouch @rleungx
pick some hot region optimization to release 2.1 (#1551)
0513b00 
*: make hot region scheduler configurable (#1412)

Signed-off-by: nolouch <nolouch@gmail.com>

* use high priority for the hot region related operators (#1492)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* schedulers: let hot region balance not affect by balance-region-scheduler-limit (#1522)

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

@nolouch nolouch nolouch approved these changes

Assignees
No one assigned
Labels
component/schedule Scheduling logic.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rleungx @codecov-io @nolouch @disksing